Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dpctl capi #666

Merged
merged 5 commits into from
Nov 10, 2021
Merged

Conversation

diptorupd
Copy link
Contributor

The name dpctl-capi is misleading and a legacy of a previous design vision for dpctl. The PR renames dpctl-capi to libsyclinterface to better reflect the intent of the helper library, i.e., to provide a C API wrapper for DPC++'s SYCL run time.

@diptorupd diptorupd marked this pull request as draft November 9, 2021 22:25
@coveralls
Copy link
Collaborator

coveralls commented Nov 9, 2021

Coverage Status

Coverage remained the same at 74.445% when pulling d453e7d on diptorupd:rename-dpctl-capi into f292953 on IntelPython:master.

@diptorupd diptorupd marked this pull request as ready for review November 10, 2021 00:18
@oleksandr-pavlyk
Copy link
Collaborator

oleksandr-pavlyk commented Nov 10, 2021

Should we then also restructure dpctl_installation_dir/include to the following layout?

  include/
    sycl_interface/
        Config/
        Support/
        *.h   /* all *.h files from present include/*.h */
    dpctl/
         dpctl_api.h    /* shallow files containing #include "../../_sycl_queue_api.h" and others */
    pybind11/
         dpctl.h        /* definitions for the C++ classes and casters to/from dpctl Python types */

@diptorupd
Copy link
Contributor Author

Should we then also restructure dpctl_installation_dir/include to the following layout?

  include/
    sycl_interface/
        Config/
        Support/
        *.h   /* all *.h files from present include/*.h */
    dpctl/
         dpctl_api.h    /* shallow files containing #include "../../_sycl_queue_api.h" and others */
    pybind11/
         dpctl.h        /* definitions for the C++ classes and casters to/from dpctl Python types */

Let us do these changes in a follow up PR.

@diptorupd diptorupd merged commit 5c3fed5 into IntelPython:master Nov 10, 2021
@diptorupd diptorupd deleted the rename-dpctl-capi branch November 10, 2021 17:37
@AndresGuzman-Ballen
Copy link
Contributor

This PR has the devil's mark :O

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants