Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

array_info_sequence handles empty sequences as host data #694

Merged
merged 2 commits into from
Nov 30, 2021
Merged

array_info_sequence handles empty sequences as host data #694

merged 2 commits into from
Nov 30, 2021

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented Nov 29, 2021 •
edited
Loading

Closes #687, #690

_array_info_sequence should handle empty sequences as host data. Added a test for this input.

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/694/index.html

@coveralls
Copy link
Collaborator

coveralls commented Nov 29, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 74.819% when pulling 5f279d6 on gh687-asarray-empty-list into ad06973 on master.

@oleksandr-pavlyk
Fixes #690
5f279d6 
Since bool is a subclass of int, the lack of missing test for
instance of bool was being handled by test for instance of int.

Fixed implementation, added a test.
@oleksandr-pavlyk oleksandr-pavlyk merged commit d9cfb43 into master Nov 30, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the gh687-asarray-empty-list branch November 30, 2021 12:51
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@densmirn densmirn densmirn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dpctl.tensor.asarray raises TypeError with empty list as input
3 participants
@oleksandr-pavlyk @coveralls @densmirn