Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A step added to build/run examples #722

Merged
merged 7 commits into from
Dec 15, 2021
Merged

A step added to build/run examples #722

merged 7 commits into from
Dec 15, 2021

Conversation

oleksandr-pavlyk
Copy link
Collaborator

conda-packages.yaml workflow add a step to build and run dpctl/examples on Linux.

This PR is to incorporate exercising examples to make sure that they are not broken by future changes.

@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Dec 12, 2021

Coverage Status

Coverage remained the same at 81.527% when pulling 3e1dc2c on test-examples into a96214c on master.

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the test-examples branch 15 times, most recently from f778716 to 629f404 Compare December 13, 2021 23:30
@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review December 14, 2021 02:00
PokhodenkoSA
PokhodenkoSA previously approved these changes Dec 14, 2021
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works.
I think overall conda-package workflow looks messy and needs refactoring. But it is separate story.

PokhodenkoSA
PokhodenkoSA previously approved these changes Dec 15, 2021
Adjust triggers to avoid duplicate jobs on push to branches with a PR

Activate and stack activate in shell session where examples are built

Only activate build_env for building packages, deactivate it before running example

Make sure to set OCL_ICD_FILENAMES before running examples
Added $CONDA_PREFIX/include to include dirs in Extensions using MKL
@oleksandr-pavlyk oleksandr-pavlyk merged commit ccd21b6 into master Dec 15, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the test-examples branch December 15, 2021 15:34
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants