Fix for issue 777, restoring versioned library symbolic links in installed package on Linux #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/778/index.html |
oleksandr-pavlyk
force-pushed
the
bugfix/gh-777
branch
from
440227c to
6136555
Compare
When scikit-build assembles dpctl, it runs cmake with "_skbuild/*/cmake-build" being its build directory, "_skbuild/*/cmake-install" being its install directory. It then runs setuptools.setup to execute build_py steps using "_skbuild/*/setuptools" as its build_base. Since sycl interface library is registered in package-data, it is copied from cmake-install (where is has symbolic links) to setuptools (where unpatched setuptools.command.build_py command follows them turning them into hard files). Then, when running install_lib step, files from _"skbuild/*/setuptools/lib/dpctl" are copied into site-packages/dpctl using copy_tree, which also follows symbolic links, hence turning them into hard links). This PR transfers logic from pre-scikit-build setup.py to fix hard links as post setuptools.command.install.run() step). A test is added to tests/test_service.py to verify that on Linux some of library files are symbolic links.
oleksandr-pavlyk
force-pushed
the
bugfix/gh-777
branch
from
6136555 to
b20d217
Compare
diptorupd
approved these changes
Feb 14, 2022
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #777
When scikit-build assembles dpctl, it runs cmake with
_skbuild/*/cmake-buildbeingas its build directory,
_skbuild/*/cmake-installbeing its install directory. It thenruns setuptools.setup to execute
build_pysteps using_skbuild/*/setuptoolsas itsbuild_base. Since sycl interface library is registered inpackage_data, it is copiedfrom
cmake-installfolder (where symbolic links are intact) tosetuptools(whereunpatched
setuptools.command.build_pycommand follows them creatinghard copies).
Then, when running
install_libstep, files from_skbuild/*/setuptools/lib/dpctlarecopied into
site-packages/dpctlusingcopy_treefunction, which also followssymbolic links this creating hard copies).
This PR transfers logic from pre-scikit-build setup.py to fix hard links as post
setuptools.command.install.run()step).A test is added to
tests/test_service.pyto verify that on Linux some of library filesare symbolic links.