Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine gemv example #833

Merged
merged 4 commits into from
May 13, 2022
Merged

Refine gemv example #833

merged 4 commits into from
May 13, 2022

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This PR modifies pybind11/onemkl_gemv example by
- plugging a device memory leak
- fixing cg_solve in solve.py to create temporaries using the same allocation queue as input arrays
- renaming C++ variables for clarity in cg_solver.hpp
- restructuring sycl_timing_solver.py to easily allow to comment out python/cpp portion invocations.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented May 13, 2022

Coverage Status

Coverage remained the same at 82.895% when pulling 50a3243 on refine-gemv-example into b196e73 on master.

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the refine-gemv-example branch 2 times, most recently from 7f3c75f to bf18061 Compare May 13, 2022 14:44
Use dpctl.tensor.empty_like, zeros_like instead of custom-defined
function.
…enable commenting out sections of the code for performance measurements
@oleksandr-pavlyk oleksandr-pavlyk merged commit b5d361f into master May 13, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the refine-gemv-example branch May 13, 2022 21:06
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants