Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array API conformity test added #901

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Array API conformity test added #901

merged 1 commit into from
Sep 8, 2022

Conversation

ndgrigorian
Copy link
Collaborator

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
    PR Python array API conformity workflow added #881 as a new PR, fixing duplicate commits

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 81.872% when pulling f6337fc on ndgrigorian:array-api-workflow into 09b2555 on IntelPython:master.

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @ndgrigorian

@oleksandr-pavlyk
Copy link
Collaborator

Both failed workflows have to do with github-action bot not having permissions to resources on forks.

Would be curious to find out how coverall solves this issue.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 5938433 into IntelPython:master Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Array API standard conformance tests failed to run.

@ndgrigorian ndgrigorian deleted the array-api-workflow branch September 9, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @oleksandr-pavlyk