Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of array metadata transfer to device #912

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Change to use USM-host allocation for packed shape/strides on the host.
USM-host allocations take less time to copy them into USM-device allocations.

The difference is going to be especially pronounced on discrete GPU devices.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

Change to use USM-host allocation for packed shape/strides on the host.
USM-host allocations take less time to copy them into USM-device allocations.

The difference is going to be especially pronounced on discrete GPU devices.
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 82.02% when pulling eef632e on use-usm-host-allocator into 0f0c926 on master.

@github-actions
Copy link

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_118.

@diptorupd
Copy link
Contributor

@oleksandr-pavlyk re: "USM-host allocations take less time to copy them into USM-device allocations."

Less time compared to what? previously were we using regular malloc?

@oleksandr-pavlyk
Copy link
Collaborator Author

q.copy<T>(standard_alloc_vector.data(), usm_device_ptr, n) is slower than q.copy<T>(usm_host_alloc_vector.data(), usm_device_ptr, n). The PR changes to use the latter.

@oleksandr-pavlyk oleksandr-pavlyk merged commit f56bd7a into master Sep 20, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the use-usm-host-allocator branch September 20, 2022 22:45
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_118.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants