Use os.add_dll_directory on Windows #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes DPCTLSyclInterface.dll library findable with Python 3.10 Python 3.10 modifies the behavior on how it looks for DLLs to make it more secure. Library provides must add it to DLL search path using 'add_dll_directory' utility for Python's internal dynamic library opener to be able to find it. This affects loading of native extensions as well, since if native extension depends on the DLL which can not be found by Python's library loader, ModuleNotFoundError is raised
oleksandr-pavlyk
requested review from
diptorupd,
AndresGuzman-Ballen and
antonwolfy
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/918/index.html |
|
Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_124. |
antonwolfy
approved these changes
Sep 27, 2022
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_124. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
DPCTLSyclInterface.dlllibrary findable with Python 3.10Python 3.10 modifies the behavior on how it looks for DLLs to make it more secure. Library provides must add it to DLL search path using 'add_dll_directory' utility for Python's internal dynamic library opener to be able to find it.
This affects loading of native extensions as well, since if native extension depends on the DLL which can not be found by Python's library loader, ModuleNotFoundError is raised