-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented dpctl.tensor.meshgrid and tests #920
Conversation
View rendered docs @ https://intelpython.github.io/dpctl/pulls/920/index.html |
Can you please either merge main branch into this PR, or rebase it on top of the main branch to fix the CI? |
ea53914
to
ddb68e8
Compare
Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_142. |
We also need a test for the case when arrays have different allocation queues. q0 = dpctl.SyclQueue()
x0 = dpt.arange(5, sycl_queue=q0)
q1 = dpctl.SyclQueue()
x1 = dpt.arange(3, sycl_queue=q1)
mgr = dpt.meshgrid((x0,x1)) Is this expected to work with resulting arrays keeping the same allocation queues as inputs for "xy" and appropriate permutation for "ij"? Or should this raise? |
Added test to check for this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @ndgrigorian
Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_150. |
@ndgrigorian please look over the changes, and let me know if it is ok to merge |
Changes look great, it should be okay to merge. Thank you @oleksandr-pavlyk. |
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_150. |
Implements dpctl.tensor.meshgrid constructor which returns a matrix of coordinates. Implemented as per array API standard.