Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed use of unnecessary compiler option --dpcpp in vendored compiler config cmake script #958

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented Nov 2, 2022

Compiler oneAPI DPC++ 2022.2.0 no longer requires use of --dpcpp option.

The work-in-progress compiler generates warnings when --dpcpp is used. Removing this flag now to be future-proof.

  • Have you provided a meaningful PR description?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

The work-in-progress compiler generates warnings when `--dpcpp` is used.
Removing this flag now to be future-proof.
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 82.033% when pulling d71101f on align_compiler_config_cmake_script_with_upcoming_changes into 85ec499 on master.

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_232 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk merged commit c487b2b into master Nov 2, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the align_compiler_config_cmake_script_with_upcoming_changes branch November 2, 2022 17:35
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_232 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants