Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce dpctl/sycl.pxd #981

Merged
merged 6 commits into from
Nov 8, 2022
Merged

Introduce dpctl/sycl.pxd #981

merged 6 commits into from
Nov 8, 2022

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This PR adds dpctl/sycl.pxd to alleviate the need for Cython extension authors to redeclare SYCL RT classes in their code, and to provide routines to cast from SYCLInterface library's opaque pointers to Sycl class pointers and back.

Example is added to test and to illustrate the usage of dpctl.sycl in Cython.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@oleksandr-pavlyk
Implements #972 by adding dpctl/sycl.pxd
78a858c 
This Cython declaration file contains incomplete redeclarations
of SYCL runtime classes, as well as wrap/unwrap casters to convert
SyclInterface opaque pointers to these.
@oleksandr-pavlyk
Added Cython example exercising dpctl.sycl
ad6bd26
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_50 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_56 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_57 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

View rendered docs @ https://intelpython.github.io/dpctl/pulls/981/index.html

@coveralls
Copy link
Collaborator

coveralls commented Nov 8, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 82.024% when pulling 73a39c1 on dpctl-sycl-pxd into 3d04af8 on master.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_59 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_60 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

diptorupd
diptorupd reviewed Nov 8, 2022
View reviewed changes
dpctl/sycl.pxd Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_60 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_62 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk merged commit 2e2e35d into master Nov 8, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the dpctl-sycl-pxd branch November 8, 2022 22:17
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_62 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Nov 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @diptorupd