Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing copy for dpctl.tensor.full() function if fill_value is array #995

Merged
merged 2 commits into from
Nov 19, 2022

Conversation

npolina4
Copy link
Collaborator

Fixed missing copy for full() function if fill_value is array.
Added tests that check order and strides for dpctl.tensor.full() function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?

@github-actions
Copy link

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0rc2=py310h8c27c75_19 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@coveralls
Copy link
Collaborator

coveralls commented Nov 19, 2022

Coverage Status

Coverage increased (+0.01%) to 81.999% when pulling 6c9a8cd on add_full_strides into 05c358e on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0rc2=py310h8c27c75_20 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @npolina4

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0rc2=py310h8c27c75_19 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk merged commit 5f82196 into master Nov 19, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the add_full_strides branch November 19, 2022 01:07
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0rc2=py310h8c27c75_19 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants