Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use_dpctl_remainder_func #1515

Merged
merged 5 commits into from
Aug 17, 2023
Merged

use_dpctl_remainder_func #1515

merged 5 commits into from
Aug 17, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Aug 8, 2023 •
edited
Loading

The PR uses dpctl.tensor implementation for dpnp.remainder function and its alias dpnp.mod.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana force-pushed the use_dpctl_remainder_func branch from 3dedb2f to ab2f4b1 Compare August 8, 2023 15:14
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana self-assigned this Aug 8, 2023
@vtavana vtavana force-pushed the use_dpctl_remainder_func branch from ab2f4b1 to 3ccba21 Compare August 10, 2023 02:50
@vtavana vtavana marked this pull request as ready for review August 10, 2023 16:43
@vtavana vtavana force-pushed the use_dpctl_remainder_func branch 2 times, most recently from a77a82b to 217057d Compare August 10, 2023 18:09
antonwolfy
antonwolfy reviewed Aug 11, 2023
View reviewed changes
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
tests/skipped_tests_gpu.tbl Show resolved Hide resolved
tests/test_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
@vtavana vtavana force-pushed the use_dpctl_remainder_func branch from 2e8794a to 7a4037a Compare August 11, 2023 16:02
antonwolfy
antonwolfy approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana ! LGTM

@vtavana vtavana force-pushed the use_dpctl_remainder_func branch 2 times, most recently from 6c461cc to 42e6ef3 Compare August 14, 2023 17:41
@vtavana vtavana force-pushed the use_dpctl_remainder_func branch 3 times, most recently from 32f5834 to c48ca99 Compare August 16, 2023 18:26
@vtavana vtavana force-pushed the use_dpctl_remainder_func branch from c48ca99 to 988ec20 Compare August 16, 2023 21:00
@vtavana vtavana merged commit 12a8dcb into master Aug 17, 2023
@vtavana vtavana deleted the use_dpctl_remainder_func branch August 17, 2023 04:52
This was referenced Aug 17, 2023
Merged
Merged
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy