-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked dpnp.copyto() implementation through existing calls #1516
Conversation
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
The following tests failed on nuc04, do they pass for you? FAILED tests/third_party/cupy/manipulation_tests/test_basic.py::TestBasic::test_copyto_broadcast - AssertionError: Only cupy raises error |
No, but the issue is in dpctl, I've raised #1334 to address the problem. |
3635ff5
to
b0237dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @antonwolfy
👍 |
The PR proposes to redesign existing implementation of
dpnp.copyto()
through existing functions instead of separate kernel. Also it adds missing support of all input parameters, which allows to completely remove fallback on numpy for the function.Additionally, more tests are added to cover the functionality.