Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dpnp.roll implementation and update dpnp.rollaxis/dpnp.moveaxis #1517

Merged
merged 10 commits into from
Aug 29, 2023
Merged

Add dpnp.roll implementation and update dpnp.rollaxis/dpnp.moveaxis #1517

merged 10 commits into from
Aug 29, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR

  • adds an implementation of dpnp.roll() that reuses dpctl.tensor.roll()
  • updates implementations and documentation for dpnp.rollaxis and dpnp.moveaxis
  • adds more tests for dpnp.roll and dpnp.rollaxis

.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Aug 9, 2023
antonwolfy
antonwolfy reviewed Aug 9, 2023
View reviewed changes
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
tests/third_party/cupy/manipulation_tests/test_rearrange.py Outdated Show resolved Hide resolved
tests/third_party/cupy/manipulation_tests/test_rearrange.py Outdated Show resolved Hide resolved
tests/third_party/cupy/manipulation_tests/test_rearrange.py
{"shape": (5, 2), "shift": (2, 1), "axis": (0, 1)},
{"shape": (5, 2), "shift": (2, 1), "axis": (0, -1)},
{"shape": (5, 2), "shift": (2, 1), "axis": (1, -1)},
{"shape": (5, 2), "shift": (2, 1, 3), "axis": 0},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any reason why you skip

{'shape': (5, 2), 'shift': (2, 1, 3), 'axis': None},

from parameterize?

tests/third_party/cupy/manipulation_tests/test_rearrange.py Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vlad-perevezentsev

@antonwolfy antonwolfy merged commit 09f7085 into master Aug 29, 2023
@antonwolfy antonwolfy deleted the dpctl_roll_rollaxis branch August 29, 2023 18:30
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy