Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align default order value with numpy in asarray-like functions #1526

Merged
merged 5 commits into from
Aug 18, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 17, 2023

The PR proposes to align default order value with numpy implementation in dpnp.array, dpnp.asarray and dpnp.asanyarray functions.

An array creation function dpnp.ascontiguousarray is extended with missing arguments and aligned with numpy.
A missing function dpnp.asfortranarray is added to dpnp.
The device keyword arguments are implemented for both functions.

The parameter like is described as currently unsupported and will cause ValueError exception if passed in each updated function. The same is about subok and ndim parameters for dpnp.array function.
No fallback on numpy will be invoked anymore for the functions.

The test scope is extended with new scenarios and previously muted tests are enabled.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this PR!
Thank you @antonwolfy

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @antonwolfy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants