Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update out keyword for elementwise functions #1656

Merged
merged 5 commits into from
Jan 17, 2024
Merged

update out keyword for elementwise functions #1656

merged 5 commits into from
Jan 17, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jan 13, 2024 •
edited
Loading

In this PR, a bug related to out keyword in elementwise functions is fixed.
In the current implementation of the elementwise functions, the output of the function and the output coming from out keyword are two different copies of the same data. The code is modified to make the output of the function a view of the output corresponding to the out keyword.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana
update out keyword elementwise
08fe8ba 
update out keyword elementwise
@vtavana vtavana self-assigned this Jan 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as draft January 13, 2024 19:28
@vtavana vtavana marked this pull request as ready for review January 15, 2024 18:15
@vtavana vtavana requested a review from antonwolfy January 15, 2024 18:15
antonwolfy
antonwolfy approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtavana. thank you for catching and resolving that!

@vtavana vtavana merged commit 75f1f97 into master Jan 17, 2024
44 of 45 checks passed
@vtavana vtavana deleted the elementwise_out_keyword branch January 17, 2024 17:13
github-actions bot added a commit that referenced this pull request Jan 17, 2024
@github-actions
update out keyword for elementwise functions (#1656)
ae12292 
* update out keyword elementwise

* improve test coverage

* address comments 75f1f97
@antonwolfy antonwolfy mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy