Update dpnp.linalg.qr() function #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html |
vlad-perevezentsev
force-pushed
the
impl_qr_new
branch
from
6baeb74 to
3b57f0c
Compare
antonwolfy
reviewed
Feb 1, 2024
antonwolfy
reviewed
Feb 6, 2024
|
I skipped
Use of new MKL version packages for coverage build will be when dpcpp_linux-64 2024.1.0 is released. |
antonwolfy
reviewed
Feb 7, 2024
antonwolfy
approved these changes
Feb 8, 2024
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Feb 8, 2024
* Impl dpnp.linalg.qr for 2d array * Add cupy tests for dpnp.linalg.qr * Add batch implementation of dpnp.linalg.qr * Remove an old impl of dpnp_qr * Update test_qr in test_sycl_queue * Add test_qr in test_usm_type * Use _real_type for _orgqr * Use _real_type for _orgqr_batch * Update dpnp tests for dpnp.linalg.qr * Pass scratchpad_size to the error message test * Add additional checks * Extend error handler for mkl batch funcs * Add ungqr mkl extension to support complex dtype * Update tau array size check for orgqr * Add ungqr_batch mkl extension to support complex dtype * Add arrays type check * Fix test_det_singular_matrix * Expand tests for dpnp.linalg.qr with complex types * Update examples * Remove astype for output arrays * Use empty_like instead of empty * Use ht_list_ev with dpctl.SyclEvent.wait_for * Add _triu_inplace func * Use copy_usm for a_t array overwritten by geqrf/geqrf_batch --------- Co-authored-by: Anton <[email protected]> 1e86753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update
dpnp.linalg.qr()function to calculate the QR decomposition usingoneapi::mkl::lapack::geqrfandoneapi::mkl::lapack::orgqrThe implementation is written as a pybind11 extension above required LAPACK functions.
The changes are related to support of all types and support of function argument as
mode