Replace use of queue mgr #1735
Merged
Replace use of queue mgr #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
This is done by reverting to DPNP_LOCAL_QUEUE=1 behavior. The ultimate goal is to get rid of DPNP_QUEUE throughout dpnp codebase
Since DPNP_LOCAL_QUEUE has been removed.
oleksandr-pavlyk
force-pushed
the
replace-use-of-queue-mgr
branch
from
db48050 to
6309f26
Compare
|
This change should not have made any difference, but please see if tests say otherwise. |
Renamed backend_sycl_singleton back to backend_sycl Removed dpnp_queue_initialize_c function and QueueOptions enum as no longer used. Removed uses of these from examples and code base
antonwolfy
reviewed
Mar 19, 2024
oleksandr-pavlyk
force-pushed
the
replace-use-of-queue-mgr
branch
from
2c266f9 to
ac1b43a
Compare
antonwolfy
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
@oleksandr-pavlyk, thanks a lot for implementing a proper local queue handing in dpnp.
diptorupd
reviewed
Mar 19, 2024
diptorupd
reviewed
Mar 19, 2024
|
@antonwolfy Are we good to merge? |
antonwolfy
approved these changes
Mar 20, 2024
6 tasks
github-actions bot
added a commit
that referenced
this pull request
Mar 20, 2024
* Remove use of deprecated DPCTLQueueMgr_* functions This is done by reverting to DPNP_LOCAL_QUEUE=1 behavior. The ultimate goal is to get rid of DPNP_QUEUE throughout dpnp codebase * Removed setting DPNP_LOCAL_QUEUE in tests Since DPNP_LOCAL_QUEUE has been removed. * Removed uses of device_context * Removed trailing whitespace * Replaced tab with spaces * Use backend_sycl_singleton, remove backend_sycl * Removed pre-preprocessor fenced out dead code Renamed backend_sycl_singleton back to backend_sycl Removed dpnp_queue_initialize_c function and QueueOptions enum as no longer used. Removed uses of these from examples and code base * Formatting suggested by pre-commit hooks * Addressed issues raised by @diptorupd --------- Co-authored-by: Anton <[email protected]> b51100f
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Mar 20, 2024
* Remove use of deprecated DPCTLQueueMgr_* functions This is done by reverting to DPNP_LOCAL_QUEUE=1 behavior. The ultimate goal is to get rid of DPNP_QUEUE throughout dpnp codebase * Removed setting DPNP_LOCAL_QUEUE in tests Since DPNP_LOCAL_QUEUE has been removed. * Removed uses of device_context * Removed trailing whitespace * Replaced tab with spaces * Use backend_sycl_singleton, remove backend_sycl * Removed pre-preprocessor fenced out dead code Renamed backend_sycl_singleton back to backend_sycl Removed dpnp_queue_initialize_c function and QueueOptions enum as no longer used. Removed uses of these from examples and code base * Formatting suggested by pre-commit hooks * Addressed issues raised by @diptorupd --------- Co-authored-by: Anton <[email protected]> b51100f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPCTLQueueMgr_*is being removed, see IntelPython/dpctl#1576.This PR removes use of
DPCTLQueueMgr_*inqueue_sycl.cppandqueue_sycl.hpp.It effectively reverts to using
DPNP_LOCAL_QUEUE=1.Examples, documentation were also updated to avoid uses of
device_selectoras it is being removed.