Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove find_common_type which is never used in DPNP and deprecated since NumPy 1.25.0 #1742

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Remove find_common_type which is never used in DPNP and deprecated since NumPy 1.25.0 #1742

merged 2 commits into from
Mar 13, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 13, 2024 •
edited
Loading

The PR removes unused function find_common_type from Cython backend layout.
The function also was present in NumPy and deprecated since 1.25.0, so also the PR proposes removing documentation reference on it.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Mar 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 13, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vlad-perevezentsev
vlad-perevezentsev approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit de25db0 into master Mar 13, 2024
45 checks passed
@antonwolfy antonwolfy deleted the remove-unused-function branch March 13, 2024 10:16
github-actions bot added a commit that referenced this pull request Mar 13, 2024
@github-actions
Remove find_common_type which is never used in DPNP and deprecated si…
25faf29 
…nce NumPy 1.25.0 (#1742) de25db0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev