Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dpnp.sort_complex function #1864

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Implement dpnp.sort_complex function #1864

merged 3 commits into from
Jun 4, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 31, 2024 •
edited
Loading

The PR add implementation for dpnp.sort_complex function through call of dpnp.sort function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this May 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 31, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vlad-perevezentsev
vlad-perevezentsev approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 006ccf9 into master Jun 4, 2024
56 checks passed
@antonwolfy antonwolfy deleted the impl-sort_complex branch June 4, 2024 15:10
github-actions bot added a commit that referenced this pull request Jun 4, 2024
@github-actions
Implement dpnp.sort_complex function (#1864)
a00d023 
* Implement dpnp.sort_complex

* Improve test coverage 006ccf9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev