Rework implementation of dpnp.fmax and dpnp.fmin functions
#1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
github-actions bot
added a commit
that referenced
this pull request
Jul 4, 2024
* Implement dpnp.fmax and dpnp.fmin functions * Updated existing tests and added new ones * Removed unused code from cython backend * Removed a reference to original descriptor 05e1bb6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to rework implementation of
dpnp.fmaxanddpnp.fminfunctions which are quite limited now.There is new VM functions are added to use
fmaxandfminfrom OneMKL library where it's possible.Also the PR adds new binary universal functions
_fmaxand_fminto_ufunc_implpybind11 extension which leverages on dpctl f/w.The all affected tests are updated to cover different use cases.