Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code duplication for sorting functions #1914

Merged
merged 24 commits into from
Jul 10, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 7, 2024

The PR proposes to decouple a common implementation of dpnp.sort and dpnp.argsort into an internal function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Jul 7, 2024

View rendered docs @ https://intelpython.github.io/dpnp/pull/1914/index.html

@antonwolfy antonwolfy force-pushed the adopt-indexing-if-to-asynchronous-dpctl-execution branch from f4e3917 to f53ab2d Compare July 9, 2024 12:59
@antonwolfy antonwolfy force-pushed the adopt-sorting-if-to-asynchronous-dpctl-execution branch from 5b7e867 to a682406 Compare July 9, 2024 14:08
@antonwolfy antonwolfy changed the title Adopt dpnp interface to asynchronous dpctl execution (sorting routine) Reduce code duplication for sorting functions Jul 9, 2024
Base automatically changed from adopt-indexing-if-to-asynchronous-dpctl-execution to master July 10, 2024 14:36
@antonwolfy antonwolfy merged commit 001b63f into master Jul 10, 2024
30 of 45 checks passed
@antonwolfy antonwolfy deleted the adopt-sorting-if-to-asynchronous-dpctl-execution branch July 10, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants