-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce code duplication for sorting functions #1914
Merged
antonwolfy
merged 24 commits into
master
from
adopt-sorting-if-to-asynchronous-dpctl-execution
Jul 10, 2024
Merged
Reduce code duplication for sorting functions #1914
antonwolfy
merged 24 commits into
master
from
adopt-sorting-if-to-asynchronous-dpctl-execution
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/pull/1914/index.html |
antonwolfy
force-pushed
the
adopt-indexing-if-to-asynchronous-dpctl-execution
branch
from
July 9, 2024 12:59
f4e3917
to
f53ab2d
Compare
…d back data synchronization
antonwolfy
force-pushed
the
adopt-sorting-if-to-asynchronous-dpctl-execution
branch
from
July 9, 2024 14:08
5b7e867
to
a682406
Compare
antonwolfy
changed the title
Adopt dpnp interface to asynchronous dpctl execution (sorting routine)
Reduce code duplication for sorting functions
Jul 9, 2024
npolina4
approved these changes
Jul 9, 2024
vtavana
approved these changes
Jul 9, 2024
Base automatically changed from
adopt-indexing-if-to-asynchronous-dpctl-execution
to
master
July 10, 2024 14:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to decouple a common implementation of
dpnp.sort
anddpnp.argsort
into an internal function.