-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation of dpnp.float_power
#1957
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vlad-perevezentsev
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you @antonwolfy
github-actions bot
added a commit
that referenced
this pull request
Aug 7, 2024
* Add implementation of dpnp.float_power() * Updated third party tests * Added more tests to cover different scenarios * Mute back test for dpnp.floor_divide * Update docstring with another way to state NaN value * Address comment to update tests cfaae8c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds implementation of
dpnp.float_power
functions.There is no dedicated function added to
_ufunc_impl
extension but reused_pow
functions from dpctl.tensor and from VM extension. The only function which was required to be implemented is_float_power_result_type
to redefine a table with supported data types.Unlike numpy,
dpnp.float_power
has to support also float32 and complex64 data types. It is done to work on a device without fp64 support,Third party tests are updated, affected tests are unmuted, new ones are added to cover more use cases.