Move dpnp.from_dlpack to array creation routine
#2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
force-pushed
the
move-from_dlpack-to-array-creation-routine
branch
from
7d1c321 to
1e29cef
Compare
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
vtavana
approved these changes
Dec 4, 2024
Co-authored-by: Vahid Tavanashad <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Dec 5, 2024
The PR proposes to move `dpnp.from_dlpack` function to `dpnp/dpnp_iface_arraycreation.py` and to update docstring description, because there were formatting issues within rendered documentation of `dpnp.from_dlpack`. Also sphinx configuration was tuned to add mapping towards dpctl documentation pages. e53fa72
antonwolfy
added a commit
that referenced
this pull request
Dec 6, 2024
The PR proposes to move `dpnp.from_dlpack` function to `dpnp/dpnp_iface_arraycreation.py` and to update docstring description, because there were formatting issues within rendered documentation of `dpnp.from_dlpack`. Also sphinx configuration was tuned to add mapping towards dpctl documentation pages.
antonwolfy
added a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to move
dpnp.from_dlpackfunction todpnp/dpnp_iface_arraycreation.pyand to update docstring description, because there were formatting issues with rendered documentation ofdpnp.from_dlpack.Also sphinx configuration was tuned to add mapping towards dpctl documentation pages.