Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the declaration of drt_debug_print into a header. #1005

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

diptorupd
Copy link
Contributor

  • Have you provided a meaningful PR description?
    • Fixes build error after the nrt_dbg_print was renamed to
      drt_debug_print.
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

    - Fixes build error after the nrt_dbg_print was renamed to
      drt_debug_print.
@diptorupd
Copy link
Contributor Author

The issue was after #1002 we renamed the function in all files but it was not publicly declared and defined, causing an:

error: call to undeclared function 'drt_debug_print'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

The fix is to move the function definition out of _dpexrt_python.c into _dbg_printer.h and then include _dbg_printer.h everywhere.

@diptorupd diptorupd merged commit aac91b8 into main Apr 17, 2023
@diptorupd diptorupd deleted the fix/build_error branch April 17, 2023 00:42
github-actions bot added a commit that referenced this pull request Apr 17, 2023
Move the declaration of drt_debug_print into a header. aac91b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant