Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jenkins CI #1072

Merged
merged 4 commits into from
Jun 17, 2023
Merged

Fix jenkins CI #1072

merged 4 commits into from
Jun 17, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Jun 15, 2023

Update conda-recipe tests to run on every cpu and gpu sycl selector.
Skip failing tests

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Jun 15, 2023
@ZzEeKkAa ZzEeKkAa changed the title Fix jenkins ci Fix jenkins CI Jun 15, 2023
@diptorupd diptorupd force-pushed the fix/jenkins_ci branch 2 times, most recently from 186ccb9 to fbc1090 Compare June 17, 2023 05:56
ZzEeKkAa and others added 4 commits June 17, 2023 02:18
   - Previously, any dpnp.ndarray objects used as an argument in a
     parfor was a numba_dpex.core.types.DpnpNdArray. The commit changes
     that and casts all dpnp.ndarray arguments of a parfor to
     numba_dpex.core.types.USMNdArray.

     The reason for the change is as follows:

     Although, DpnpNdArray derives from USMNdArray the two types use
     different data models. USMNdArray uses the
     numba_dpex.core.datamodel.models.ArrayModel data model that defines all
     CPointer type members in the GLOBAL address space. The DpnpNdArray uses
     Numba's default ArrayModel that does not define pointers in any specific
     address space. For OpenCL HD Graphics devices, defining a kernel
     function (spir_kernel calling convention) with pointer arguments that
     have no address space qualifier causes a run time crash. By casting
     the argument type for parfor arguments from DpnpNdArray type to the
     USMNdArray type the generated kernel always has an address space
     qualifier, avoiding the issue on OpenCL HD graphics devices.
@diptorupd diptorupd merged commit a33c03f into main Jun 17, 2023
@diptorupd diptorupd deleted the fix/jenkins_ci branch June 17, 2023 07:18
github-actions bot added a commit that referenced this pull request Jun 17, 2023
github-actions bot pushed a commit that referenced this pull request Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants