Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scikit-build setup.py for numba-dpex #1107

Merged
merged 2 commits into from
Aug 22, 2023
Merged

scikit-build setup.py for numba-dpex #1107

merged 2 commits into from
Aug 22, 2023

Conversation

chudur-budur
Copy link
Contributor

@chudur-budur chudur-budur commented Aug 2, 2023 •
edited
Loading

We need to switch to scikit-build based setup.

This will make easy to integrate/compile different extensions and libraries with orthogonal requirements.

JIRA Reference: SAT-6040

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@chudur-budur chudur-budur force-pushed the refac/new-setup-skbuild branch 2 times, most recently from 0750d76 to 9d98c92 Compare August 6, 2023 23:46
@chudur-budur chudur-budur force-pushed the refac/new-setup-skbuild branch 5 times, most recently from a81228c to bf4e573 Compare August 10, 2023 22:25
@chudur-budur chudur-budur marked this pull request as ready for review August 10, 2023 22:53
@chudur-budur
Copy link
Contributor Author

@diptorupd @ZzEeKkAa

I think it's ready for merge now. Could you please review?

@chudur-budur chudur-budur requested a review from ZzEeKkAa August 11, 2023 14:09
@chudur-budur chudur-budur force-pushed the refac/new-setup-skbuild branch from bf4e573 to 239470f Compare August 11, 2023 21:49
diptorupd
diptorupd suggested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits should be squashed into a single one.

Also a separate commit should update the Getting Started documentation and README

@chudur-budur chudur-budur force-pushed the refac/new-setup-skbuild branch 3 times, most recently from 9bf6388 to 3eca16b Compare August 15, 2023 19:24
@chudur-budur
Copy link
Contributor Author

The commits should be squashed into a single one.

done

Also a separate commit should update the Getting Started documentation and README

I can't change the docs on this branch, should I push the updated docs directly into the gh-pages branch?

@diptorupd
Copy link
Contributor

I can't change the docs on this branch, should I push the updated docs directly into the gh-pages branch?

You can create a separate branch on IntelPython/numba-dpex with the documentation changes and then open a PR off that branch. gh-pages stores the generated docs and we should never push anything directly to that branch.

diptorupd
diptorupd reviewed Aug 16, 2023
View reviewed changes
conda-recipe/meta.yaml Outdated Show resolved Hide resolved
diptorupd
diptorupd reviewed Aug 16, 2023
View reviewed changes
environment.yml Outdated Show resolved Hide resolved
diptorupd
diptorupd approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine. We need to add a version check for cmake in the meta.yml and environment.yml files.

The other comment about using the FindDpctl macro can perhaps be side stepped for now.

@diptorupd diptorupd force-pushed the refac/new-setup-skbuild branch from 91a09e3 to f8f7e6a Compare August 18, 2023 14:42
@chudur-budur
Copy link
Contributor Author

chudur-budur commented Aug 18, 2023 •
edited
Loading

The other comment about using the FindDpctl macro can perhaps be side stepped for now.

FindDpctl macro doesn't set the dpctl library directory or path, so we had to set it manually. We can change that macro in dpctl upstream and open a PR to their repo if needed.

@chudur-budur chudur-budur force-pushed the refac/new-setup-skbuild branch from f8f7e6a to 19ec3b3 Compare August 18, 2023 18:11
@chudur-budur chudur-budur mentioned this pull request Aug 18, 2023
Merged
5 tasks
@chudur-budur
Build script for skbuild and adding CMakeLists.txt
d9d38cb 
No need for *.cl and *.spir in MANIFEST

Fix ninja problem

Add 2nd level CMakeLists

Add build-system to toml

Adding CMakeLists for the runtime

Partially functional runtime CMakeLists

Functional skbuild script with all CMakeLists

Add scikit-build in conda-recipe and environment.yml

Add license to setup.py

Missing >=

Add scikit-build to environment/coverage.yml

Failsafe find_package(PythonLibs REQUIRED)

Add cmake to conda env

Fix CI build issues

setup.py docs fix

Debug github CI test issues

Fix jenkins
@chudur-budur
Add version numbers
511c2bc
@chudur-budur chudur-budur force-pushed the refac/new-setup-skbuild branch from 19ec3b3 to 511c2bc Compare August 20, 2023 07:35
@diptorupd diptorupd merged commit 8c15f5a into IntelPython:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@ZzEeKkAa ZzEeKkAa Awaiting requested review from ZzEeKkAa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chudur-budur @diptorupd @ZzEeKkAa