Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not build for python 3.8 in Github CI #1113

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Do not build for python 3.8 in Github CI #1113

merged 1 commit into from
Aug 23, 2023

Conversation

diptorupd
Copy link
Contributor

@diptorupd diptorupd commented Aug 18, 2023 •
edited
Loading

Python 3.8 is no longer officially supported.

Fixes #1114

@diptorupd diptorupd requested a review from ZzEeKkAa August 18, 2023 03:36
@diptorupd diptorupd force-pushed the remove/github_build_for_py38 branch from 42585f0 to 2e98799 Compare August 18, 2023 04:41
ZzEeKkAa
ZzEeKkAa suggested changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versioneer.py, docker.yml, _nrt_python_helper.c, and all other occurs in conda-package.yml should be updated as well.

P.S.: we can update conda-package.yml, so it takes python versions just from one place, not setting it 3 or 4 times.

@diptorupd diptorupd force-pushed the remove/github_build_for_py38 branch from 2e98799 to d812247 Compare August 19, 2023 06:19
@diptorupd
Copy link
Contributor Author

versioneer.py, docker.yml, _nrt_python_helper.c, and all other occurs in conda-package.yml should be updated as well.

P.S.: we can update conda-package.yml, so it takes python versions just from one place, not setting it 3 or 4 times.

Done. I left versioneer.py alone as it is a vendored copy of versioneer.

@diptorupd diptorupd requested a review from ZzEeKkAa August 19, 2023 06:21
@diptorupd diptorupd force-pushed the remove/github_build_for_py38 branch 2 times, most recently from 2243ba0 to 1d3ec26 Compare August 20, 2023 18:02
@diptorupd diptorupd force-pushed the remove/github_build_for_py38 branch from 1d3ec26 to c608d23 Compare August 23, 2023 16:17
ZzEeKkAa
ZzEeKkAa approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diptorupd diptorupd merged commit f9ca96b into main Aug 23, 2023
@diptorupd diptorupd deleted the remove/github_build_for_py38 branch August 23, 2023 20:58
github-actions bot added a commit that referenced this pull request Aug 23, 2023
@github-actions
Merge pull request #1113 from IntelPython/remove/github_build_for_py38
39077c5 
Do not build for python 3.8 in Github CI f9ca96b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZzEeKkAa ZzEeKkAa ZzEeKkAa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.8 in GH action conda-packages.yaml workflow
2 participants
@diptorupd @ZzEeKkAa