Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated FindPythonLibs #1127

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Remove deprecated FindPythonLibs #1127

merged 2 commits into from
Sep 12, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Sep 5, 2023 •
edited
Loading

Remove deprecated FindPythonLibs dependencies since they are no longer supported by CMake 3.27.

Blocked by IntelPython/dpctl#1389

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Close #1125

@ZzEeKkAa ZzEeKkAa self-assigned this Sep 5, 2023
@ZzEeKkAa
Copy link
Contributor Author

ZzEeKkAa commented Sep 6, 2023

I was able to test it locally with IntelPython/dpctl#1389 changes applied to dpctl and all tests are passing on CPU on my laptop.

@diptorupd diptorupd changed the title Remove depricated FindPythonLibs Remove deprecated FindPythonLibs Sep 6, 2023
@ZzEeKkAa ZzEeKkAa force-pushed the fix/remove_deprecated_find_python_libs branch from 36d938b to 3260fdf Compare September 11, 2023 14:58
@ZzEeKkAa ZzEeKkAa force-pushed the fix/remove_deprecated_find_python_libs branch from 3260fdf to ed215b5 Compare September 11, 2023 15:00
@ZzEeKkAa ZzEeKkAa mentioned this pull request Sep 11, 2023
Closed
5 tasks
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review September 11, 2023 15:41
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd as a code owner September 11, 2023 15:41
@diptorupd diptorupd merged commit 8b0d09c into main Sep 12, 2023
@diptorupd diptorupd deleted the fix/remove_deprecated_find_python_libs branch September 12, 2023 16:47
github-actions bot added a commit that referenced this pull request Sep 12, 2023
@github-actions
Merge pull request #1127 from IntelPython/fix/remove_deprecated_find_…
365e9dd 
…python_libs

Remove deprecated FindPythonLibs 8b0d09c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd