Add sycl event #1134
Merged
Add sycl event #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZzEeKkAa
force-pushed
the
feature/add_sycl_event
branch
6 times, most recently
from
b62880c to
681a232
Compare
ZzEeKkAa
force-pushed
the
feature/add_sycl_event
branch
7 times, most recently
from
a0ce2a2 to
eb2c88c
Compare
diptorupd
reviewed
Sep 29, 2023
diptorupd
reviewed
Sep 29, 2023
| error: | ||
| // If the check failed then decrement the refcount and return an error | ||
| // code of -1. | ||
| // Decref the Pyobject of the array |
There was a problem hiding this comment.
The comment needs to be removed as well.
There was a problem hiding this comment.
Let's reconsider if we still need this inc/dec ref. Still the case when it used asynchronously from the python flow may cause gc to deallocate object. It is not a case with numpy in numba because we are doing incref for memory data.
There was a problem hiding this comment.
We need to check if numba does it for us out of the box.
diptorupd
reviewed
Sep 29, 2023
diptorupd
reviewed
Sep 29, 2023
diptorupd
suggested changes
Sep 29, 2023
ZzEeKkAa
force-pushed
the
feature/add_sycl_event
branch
from
eb2c88c to
95f35ef
Compare
diptorupd
approved these changes
Sep 29, 2023
github-actions bot
added a commit
that referenced
this pull request
Sep 29, 2023
Add sycl event 26cba6c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dpctl.SyclEvent to numba friendly types, so that we can convert kernel dispatcher into @dpjit function.
Closes: #1137