Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sycl event wait overload #1179

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add sycl event wait overload #1179

merged 1 commit into from
Oct 20, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Oct 18, 2023 •
edited
Loading

Add dpctl.SyclEvent.wait() overload for dpjit functions.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Closes: #1138

@ZzEeKkAa ZzEeKkAa self-assigned this Oct 18, 2023
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_sycl_event_wait branch from 7695abd to f904a77 Compare October 18, 2023 18:58
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review October 18, 2023 18:59
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd as a code owner October 18, 2023 18:59
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_sycl_event_wait branch from f904a77 to 899e7ee Compare October 19, 2023 13:57
@ZzEeKkAa ZzEeKkAa marked this pull request as draft October 19, 2023 19:48
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_sycl_event_wait branch from 899e7ee to 355af47 Compare October 20, 2023 19:28
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_sycl_event_wait branch from 355af47 to 1ded0a6 Compare October 20, 2023 21:39
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review October 20, 2023 21:40
diptorupd
diptorupd approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me.

@ZzEeKkAa ZzEeKkAa merged commit 067cbbb into main Oct 20, 2023
21 checks passed
@ZzEeKkAa ZzEeKkAa deleted the feature/add_sycl_event_wait branch October 20, 2023 22:12
github-actions bot added a commit that referenced this pull request Oct 20, 2023
@github-actions
Merge pull request #1179 from IntelPython/feature/add_sycl_event_wait 0…
4988c7f 
…67cbbb
github-actions bot added a commit to diptorupd/numba-dpex that referenced this pull request Oct 25, 2023
@github-actions
Merge pull request IntelPython#1179 from IntelPython/feature/add_sycl…
4f85f5f 
…_event_wait 067cbbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DpctlSyclEvent] Overload syclevent wait method, so it can be used in numba
2 participants
@ZzEeKkAa @diptorupd