Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added gdb tests in CI #1209

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Added gdb tests in CI #1209

merged 1 commit into from
Nov 15, 2023

Conversation

roxx30198
Copy link
Contributor

@roxx30198 roxx30198 commented Nov 6, 2023 •
edited
Loading

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Added gdb tests for CI and mark the failing tests as xfail or skip.
Closes #1189

@roxx30198 roxx30198 requested a review from ZzEeKkAa November 6, 2023 23:26
@roxx30198 roxx30198 requested a review from diptorupd as a code owner November 6, 2023 23:26
@roxx30198 roxx30198 force-pushed the ci_gdb branch 5 times, most recently from 29d5615 to 5190d5d Compare November 7, 2023 02:44
@roxx30198 roxx30198 marked this pull request as draft November 7, 2023 15:23
@roxx30198 roxx30198 force-pushed the ci_gdb branch 7 times, most recently from 2a23208 to 3abc8bd Compare November 7, 2023 20:52
@roxx30198 roxx30198 self-assigned this Nov 7, 2023
@roxx30198 roxx30198 force-pushed the ci_gdb branch 8 times, most recently from 3f798c7 to 931b9ad Compare November 9, 2023 16:18
@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Nov 9, 2023

You have all gdb tests skipped ============================= 40 skipped in 0.84s ==============================.

It is likely because oneapi gdb environment variables are not transferred between steps. Try running setenv in the same step as running gdb tests

@roxx30198 roxx30198 force-pushed the ci_gdb branch 5 times, most recently from 0b56eb9 to dc86a08 Compare November 13, 2023 20:47
@roxx30198 roxx30198 force-pushed the ci_gdb branch 5 times, most recently from a945da6 to 6319341 Compare November 14, 2023 22:21
@roxx30198 roxx30198 closed this Nov 14, 2023
@roxx30198 roxx30198 deleted the ci_gdb branch November 14, 2023 22:41
@roxx30198 roxx30198 restored the ci_gdb branch November 14, 2023 23:03
@roxx30198 roxx30198 reopened this Nov 14, 2023
@roxx30198 roxx30198 force-pushed the ci_gdb branch 2 times, most recently from 88a085d to 39d4ea3 Compare November 14, 2023 23:48
@roxx30198 roxx30198 force-pushed the ci_gdb branch 4 times, most recently from 6c7601f to 8caa01d Compare November 15, 2023 16:54
@roxx30198 roxx30198 force-pushed the ci_gdb branch 2 times, most recently from 539a36e to 7a3fc53 Compare November 15, 2023 17:46
@ZzEeKkAa ZzEeKkAa enabled auto-merge November 15, 2023 20:53
@ZzEeKkAa ZzEeKkAa merged commit 6ca670d into IntelPython:main Nov 15, 2023
29 checks passed
@ZzEeKkAa
Copy link
Contributor

LGTM! Thank you!

@roxx30198 roxx30198 deleted the ci_gdb branch November 15, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZzEeKkAa ZzEeKkAa ZzEeKkAa approved these changes

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees

@roxx30198 roxx30198

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run GDB tests for numba-dpex on public GitHub Actions
2 participants
@roxx30198 @ZzEeKkAa