Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to sycl compiler #1210

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Switch to sycl compiler #1210

merged 1 commit into from
Nov 14, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Nov 7, 2023 •
edited
Loading

Switch compiler to sycl. It may not pass tests with actual sycl code. In this case we need add patch similar to dpctl: https://github.com/IntelPython/dpctl/blob/master/conda-recipe/bld.bat#L25-L33

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Nov 7, 2023
@ZzEeKkAa ZzEeKkAa force-pushed the feature/switch_to_sycl_compiler branch from 066ea2f to 8aab534 Compare November 7, 2023 20:57
@ZzEeKkAa ZzEeKkAa requested a review from chudur-budur November 7, 2023 21:31
chudur-budur
chudur-budur approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@chudur-budur chudur-budur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Note: The two jenkins tests that are failing are from dpctl, @oleksandr-pavlyk has already upstreamed the fix, if I am correct.

@chudur-budur chudur-budur force-pushed the feature/switch_to_sycl_compiler branch 3 times, most recently from b2a63a9 to d0592a5 Compare November 8, 2023 22:08
@ZzEeKkAa ZzEeKkAa force-pushed the feature/switch_to_sycl_compiler branch from d0592a5 to 73eedc0 Compare November 14, 2023 14:29
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review November 14, 2023 14:30
@ZzEeKkAa ZzEeKkAa enabled auto-merge November 14, 2023 14:30
@ZzEeKkAa ZzEeKkAa force-pushed the feature/switch_to_sycl_compiler branch 2 times, most recently from b9ba42a to 60b17f9 Compare November 14, 2023 15:21
@ZzEeKkAa ZzEeKkAa force-pushed the feature/switch_to_sycl_compiler branch from 60b17f9 to 5f70c5c Compare November 14, 2023 15:41
@ZzEeKkAa ZzEeKkAa merged commit 35890ba into main Nov 14, 2023
22 checks passed
@ZzEeKkAa ZzEeKkAa deleted the feature/switch_to_sycl_compiler branch November 14, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd left review comments

@chudur-budur chudur-budur chudur-budur approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZzEeKkAa @chudur-budur @diptorupd