Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move versioneer and pytest configs into pyproject.toml #1212

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

diptorupd
Copy link
Contributor

We were using setup.cfg to define the configuration options for versioneer and pytest. Both of these can be moved into pyproject.toml.

The PR moves the configurations from setup.cfg to pyproject.toml and removes setup.cfg.

@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Nov 13, 2023

Generate coverage and push to Coveralls.io is not triggered because of:

name: Coverage
on:
  push:
    branches:
      - main
  pull_request:
    paths:
      - 'numba_dpex/**'
      - environment/coverage.yml

It simply is not triggered...

UPD: why pytest kept in setup.cfg ?

@diptorupd
Copy link
Contributor Author

UPD: why pytest kept in setup.cfg ?

I was experimenting, to see what changed to impact the coverage workflow.

@diptorupd diptorupd force-pushed the remove/setup.cfg branch 2 times, most recently from 4977622 to 557151a Compare November 13, 2023 22:18
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@diptorupd diptorupd force-pushed the remove/setup.cfg branch 2 times, most recently from ccadeac to a1d6721 Compare November 14, 2023 00:48
    - Remove setup.cfg
    - Update coverage workflow
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ZzEeKkAa ZzEeKkAa merged commit f38d005 into main Nov 14, 2023
23 checks passed
@ZzEeKkAa ZzEeKkAa deleted the remove/setup.cfg branch November 14, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants