Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sycl event constructor overload #1218

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Add sycl event constructor overload #1218

merged 3 commits into from
Nov 15, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Nov 15, 2023 •
edited
Loading

Introduce a way to define sycl event inside dpjit and return it back to python.

  • SyclEvent() is overloaded.
  • syclevent_to_python handles structures without parent.
  • datamodel was extended to have parent (same as in sycl queue).

PR checks:

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Closes: #1184

@ZzEeKkAa ZzEeKkAa self-assigned this Nov 15, 2023
@diptorupd diptorupd changed the title Add sycl event custructor overload Add sycl event constructor overload Nov 15, 2023
@ZzEeKkAa ZzEeKkAa force-pushed the feature/overload_syclevent branch 4 times, most recently from f49915d to a598cf5 Compare November 15, 2023 17:50
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review November 15, 2023 17:59
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd as a code owner November 15, 2023 17:59
@ZzEeKkAa ZzEeKkAa marked this pull request as draft November 15, 2023 18:05
@ZzEeKkAa ZzEeKkAa force-pushed the feature/overload_syclevent branch 3 times, most recently from f305147 to 85578e9 Compare November 15, 2023 18:27
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review November 15, 2023 18:28
@ZzEeKkAa ZzEeKkAa enabled auto-merge November 15, 2023 18:28
@ZzEeKkAa ZzEeKkAa force-pushed the feature/overload_syclevent branch from 85578e9 to f83f5d4 Compare November 15, 2023 18:34
@ZzEeKkAa ZzEeKkAa force-pushed the feature/overload_syclevent branch 2 times, most recently from 279441c to bc0e16d Compare November 15, 2023 18:48
@ZzEeKkAa ZzEeKkAa force-pushed the feature/overload_syclevent branch 2 times, most recently from 1171684 to 906eec6 Compare November 15, 2023 20:06
@ZzEeKkAa ZzEeKkAa force-pushed the feature/overload_syclevent branch from 906eec6 to 1fe4ad0 Compare November 15, 2023 20:54
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd November 15, 2023 21:19
@ZzEeKkAa ZzEeKkAa merged commit ca8e769 into main Nov 15, 2023
29 checks passed
@ZzEeKkAa ZzEeKkAa deleted the feature/overload_syclevent branch November 15, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DpctlSyclEvent] Overload SyclEvent creation
2 participants
@ZzEeKkAa @diptorupd