-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable SPIR-V to device caching #1236
Conversation
94bfb6a
to
f441804
Compare
f441804
to
3c19872
Compare
3c19872
to
e68ada4
Compare
d298a22
to
471ced0
Compare
# TODO: Enable caching
# Add code to enable on disk caching of a binary spirv kernel.
# Refer: https://github.com/IntelPython/numba-dpex/issues/1197 No, that is a different issue. Numba supports ahead of time (AOT) compilation using on disk caching of compiled binaries. That way if you run a function with |
28dd515
to
1c9dbcf
Compare
1c9dbcf
to
9a2f1a0
Compare
9a2f1a0
to
a8178c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! One step closer to making the experimental kernel really usable. :)
…ice_caching Enable SPIR-V to device caching 8fc7fbd
…pirv_to_device_caching Enable SPIR-V to device caching 8fc7fbd
Add kernel reference caching for the SPIRV to device compilation. This is a critical change to make experimental kernels usable.
Should we remove comment from
kernel_dispatcher.py
?I've add simple test to check if second run does not crash XD. I've made sure that kernel reference is taking from cache by enabling logs and making sure it reached right place.
Since we can not implement caching on kernel dispatcher level due to missing information about context that is available only at runtime, I guess we can close this issue.
Closes: #1070