Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds memory enum classes to the experimental module #1239

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

diptorupd
Copy link
Contributor

  • Have you provided a meaningful PR description?

The PR adds a new kernel_iface module to numba_dpex.experimental and a Python representation of dpcpp/SYCL's memeory enum classes. The three new Enum classes: MemoryScope, MemoryOrder, AddressSpace derive from FlagEnum and can be used as Literal flags in an experimental kernel.

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd diptorupd requested a review from ZzEeKkAa December 11, 2023 21:15
Diptorup Deb added 2 commits December 11, 2023 20:28
    - A new experimental module kernel_iface was added to
      store Python implementation of the kernel API. The
      initial module has the memory enum classes that can
      be used as flags in a numba_dpex.experimental.kernel
@diptorupd diptorupd force-pushed the experimental/memory_enum_classes branch from ae96d7b to d175a3b Compare December 12, 2023 02:28
@ZzEeKkAa ZzEeKkAa merged commit 11e245c into main Dec 12, 2023
40 of 44 checks passed
@ZzEeKkAa ZzEeKkAa deleted the experimental/memory_enum_classes branch December 12, 2023 17:25
github-actions bot added a commit that referenced this pull request Dec 12, 2023
…asses

Adds memory enum classes to the experimental module 11e245c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants