Removes the deprecated feature of providing kernel launch params as lists and tuple #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
force-pushed
the
remove/deprecated_launch_params
branch
2 times, most recently
from
134d0e5 to
e016de9
Compare
ZzEeKkAa
approved these changes
Dec 19, 2023
ZzEeKkAa
force-pushed
the
remove/deprecated_launch_params
branch
from
e016de9 to
b539970
Compare
|
Tested with latest dpbench - works OK. |
github-actions bot
added a commit
that referenced
this pull request
Dec 26, 2023
…rams Removes the deprecated feature of providing kernel launch params as lists and tuple 1f0e316
github-actions bot
added a commit
to chudur-budur/numba-dpex
that referenced
this pull request
Dec 26, 2023
…d_launch_params Removes the deprecated feature of providing kernel launch params as lists and tuple 1f0e316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
numba_dpex.kernelfunctions can be launched by providing either aRangeorNdRangeobject tonumba_dpex.core.kernel_interface.dispatcher.JitKernel.__getitem__, or the global and local sizes as lists or tuples. The use of list and tuples was deprecated a while back. This PR removes the deprecated support and now onlyRangeorNdRangearguments are supported as kernel launch parameters.No, but existing tests have been fixed and updated.
Fixes #1040