-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overloads for an AtomicRef class and fetch_add method #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
force-pushed
the
experimental/atomic_ref
branch
4 times, most recently
from
December 27, 2023 22:09
3af9af5
to
f6bc84c
Compare
ZzEeKkAa
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
diptorupd
force-pushed
the
experimental/atomic_ref
branch
from
December 27, 2023 22:29
f6bc84c
to
b3b19d8
Compare
diptorupd
force-pushed
the
experimental/atomic_ref
branch
from
December 28, 2023 02:30
b3b19d8
to
6497c26
Compare
ZzEeKkAa
force-pushed
the
experimental/atomic_ref
branch
from
December 28, 2023 19:25
6497c26
to
594b8b7
Compare
ZzEeKkAa
force-pushed
the
experimental/atomic_ref
branch
from
December 28, 2023 19:28
594b8b7
to
147da67
Compare
github-actions bot
added a commit
that referenced
this pull request
Dec 28, 2023
Overloads for an AtomicRef class and fetch_add method 474212e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
AtomicRef
class to the experimentalkernel_iface
module to mimicsycl::atomic_ref
class. The class includes Python functions to simulate the atomicfetch_*
functions in SYCL.The
AtomicRef
class is also overloaded and an overloaded implementation is provided for the class constructor and thefetch_add
method was also added.UPD: one bug was introduced/discovered along with a workaround: #1262