Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add call_kernel for the old kernel #1260

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Add call_kernel for the old kernel #1260

merged 1 commit into from
Dec 28, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Dec 27, 2023 •
edited
Loading

Add call_kernel for the outdated kernel to make transfer to experimental kernel smoother.

Easy way to update usage (not perfect, but would work with trivial cases):

([A-Za-z_\(\)]*)\[(.*Range.*)\]\((.*)\)
dpex.call_kernel($1, $2, $3)
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa force-pushed the feature/syntax_sugar_call_kernel branch from 8d33921 to be8cfcb Compare December 27, 2023 22:48
@ZzEeKkAa ZzEeKkAa self-assigned this Dec 27, 2023
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd December 27, 2023 22:51
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review December 27, 2023 22:51
@diptorupd diptorupd merged commit 96c3d44 into main Dec 28, 2023
40 of 44 checks passed
@diptorupd diptorupd deleted the feature/syntax_sugar_call_kernel branch December 28, 2023 00:29
github-actions bot added a commit that referenced this pull request Dec 28, 2023
@github-actions
Merge pull request #1260 from IntelPython/feature/syntax_sugar_call_k…
10cef51 
…ernel

Add call_kernel for the old kernel 96c3d44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@chudur-budur chudur-budur Awaiting requested review from chudur-budur

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd