Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dpctl tensor support #1263

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Add dpctl tensor support #1263

merged 5 commits into from
Jan 3, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Jan 2, 2024 •
edited
Loading

Add support for dpctl.tensor.usm_ndarray to dpjit and experimental kernel.

Several additional changes where made:

  • Apply better naming for USMNdArray/DpnpNdArray data models.
  • Fix for USMNdArray device data model.
  • Use same data type for host and separate type for device for both USMNdArray and DpnpNdArray

Checklist

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Jan 2, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_dpctl_tensor_support_to_dpjit branch 3 times, most recently from 1d993ba to 32f88e0 Compare January 3, 2024 00:27
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review January 3, 2024 00:32
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd as a code owner January 3, 2024 00:32
@ZzEeKkAa ZzEeKkAa changed the title WIP dpctl tensor support Add dpctl tensor support Jan 3, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_dpctl_tensor_support_to_dpjit branch from 32f88e0 to 33b6904 Compare January 3, 2024 16:40
@ZzEeKkAa ZzEeKkAa marked this pull request as draft January 3, 2024 16:58
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_dpctl_tensor_support_to_dpjit branch 2 times, most recently from 66feab8 to 85db219 Compare January 3, 2024 18:11
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review January 3, 2024 18:13
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_dpctl_tensor_support_to_dpjit branch from 85db219 to 983856b Compare January 3, 2024 18:14
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_dpctl_tensor_support_to_dpjit branch 3 times, most recently from c2fbc3b to 402d67a Compare January 3, 2024 21:07
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_dpctl_tensor_support_to_dpjit branch from 402d67a to 39b4cad Compare January 3, 2024 21:29
diptorupd
diptorupd approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@diptorupd diptorupd merged commit 772066e into main Jan 3, 2024
40 of 44 checks passed
@diptorupd diptorupd deleted the feature/add_dpctl_tensor_support_to_dpjit branch January 3, 2024 23:06
github-actions bot added a commit that referenced this pull request Jan 3, 2024
@github-actions
Merge pull request #1263 from IntelPython/feature/add_dpctl_tensor_su…
9671137 
…pport_to_dpjit

Add dpctl tensor support 772066e
@ZzEeKkAa ZzEeKkAa mentioned this pull request Jan 23, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd