Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of group barrier operation #1280

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

adarshyoga
Copy link
Contributor

@adarshyoga adarshyoga commented Jan 12, 2024

  • Have you provided a meaningful PR description?

This PR contains implementation of group_barrier function that synchronizes across all work-items in a work group. It also contains a test case to verify the functionality of the barrier call.

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@adarshyoga adarshyoga requested a review from diptorupd January 12, 2024 18:43
@adarshyoga adarshyoga self-assigned this Jan 12, 2024
@adarshyoga adarshyoga force-pushed the experimental/barrier_ols branch from d069324 to 8774cd4 Compare January 12, 2024 18:43
@adarshyoga adarshyoga force-pushed the experimental/barrier_ols branch from 8774cd4 to d3c480a Compare January 26, 2024 17:30
@adarshyoga adarshyoga changed the title WIP: Implementations of group and sub-group barrier operations Implementation of group barrier operation Jan 30, 2024
@adarshyoga adarshyoga force-pushed the experimental/barrier_ols branch from d3c480a to 3b8a88c Compare January 30, 2024 07:07
@adarshyoga adarshyoga marked this pull request as ready for review January 30, 2024 07:12
@adarshyoga adarshyoga force-pushed the experimental/barrier_ols branch 2 times, most recently from 01ad320 to e10a49e Compare January 30, 2024 23:02
@ZzEeKkAa ZzEeKkAa force-pushed the experimental/barrier_ols branch 2 times, most recently from de9bec1 to 8ca9551 Compare February 2, 2024 23:53
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Few nits as always

@ZzEeKkAa ZzEeKkAa force-pushed the experimental/barrier_ols branch from 8ca9551 to 769d960 Compare February 3, 2024 00:40
@ZzEeKkAa ZzEeKkAa enabled auto-merge February 3, 2024 00:57
@ZzEeKkAa ZzEeKkAa merged commit b494492 into main Feb 3, 2024
38 checks passed
@ZzEeKkAa ZzEeKkAa deleted the experimental/barrier_ols branch February 3, 2024 01:12
github-actions bot added a commit that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants