-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of group barrier operation #1280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adarshyoga
force-pushed
the
experimental/barrier_ols
branch
from
January 12, 2024 18:43
d069324
to
8774cd4
Compare
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_barriers_overloads.py
Outdated
Show resolved
Hide resolved
adarshyoga
force-pushed
the
experimental/barrier_ols
branch
from
January 26, 2024 17:30
8774cd4
to
d3c480a
Compare
adarshyoga
changed the title
WIP: Implementations of group and sub-group barrier operations
Implementation of group barrier operation
Jan 30, 2024
adarshyoga
force-pushed
the
experimental/barrier_ols
branch
from
January 30, 2024 07:07
d3c480a
to
3b8a88c
Compare
adarshyoga
force-pushed
the
experimental/barrier_ols
branch
2 times, most recently
from
January 30, 2024 23:02
01ad320
to
e10a49e
Compare
ZzEeKkAa
force-pushed
the
experimental/barrier_ols
branch
2 times, most recently
from
February 2, 2024 23:53
de9bec1
to
8ca9551
Compare
diptorupd
reviewed
Feb 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok. Few nits as always
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_barriers_overloads.py
Outdated
Show resolved
Hide resolved
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_barriers_overloads.py
Outdated
Show resolved
Hide resolved
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_barriers_overloads.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Yevhenii Havrylko <[email protected]>
ZzEeKkAa
force-pushed
the
experimental/barrier_ols
branch
from
February 3, 2024 00:40
8ca9551
to
769d960
Compare
diptorupd
approved these changes
Feb 3, 2024
github-actions bot
added a commit
that referenced
this pull request
Feb 3, 2024
Implementation of group barrier operation b494492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains implementation of group_barrier function that synchronizes across all work-items in a work group. It also contains a test case to verify the functionality of the barrier call.