Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/use dpnp specific registry #1282

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Feature/use dpnp specific registry #1282

merged 2 commits into from
Jan 22, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Jan 18, 2024 •
edited
Loading

Provide dpnp specific registry so we don't override numba's default behaviour

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Jan 18, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/use_dpnp_specific_registry branch from c438cd4 to c5de0a9 Compare January 18, 2024 15:10
@ZzEeKkAa ZzEeKkAa force-pushed the feature/use_dpnp_specific_registry branch from c5de0a9 to 947f92b Compare January 19, 2024 09:22
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd January 19, 2024 09:23
diptorupd
diptorupd approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barring the small nit about the comment, LGTM!

@ZzEeKkAa ZzEeKkAa force-pushed the feature/use_dpnp_specific_registry branch from 947f92b to 5c8f09d Compare January 22, 2024 16:06
@ZzEeKkAa ZzEeKkAa enabled auto-merge January 22, 2024 16:06
@ZzEeKkAa ZzEeKkAa merged commit 12ebcd3 into main Jan 22, 2024
33 of 39 checks passed
@ZzEeKkAa ZzEeKkAa deleted the feature/use_dpnp_specific_registry branch January 22, 2024 16:43
github-actions bot added a commit that referenced this pull request Jan 22, 2024
@github-actions
Merge pull request #1282 from IntelPython/feature/use_dpnp_specific_r…
2330969 
…egistry

Feature/use dpnp specific registry 12ebcd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@chudur-budur chudur-budur Awaiting requested review from chudur-budur

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd