Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DEFAULT_LOCAL_SIZE completely from the code #1291

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Remove DEFAULT_LOCAL_SIZE completely from the code #1291

merged 2 commits into from
Jan 23, 2024

Conversation

chudur-budur
Copy link
Contributor

Remove the DEFAULT_LOCAL_SIZE from the codebase.

This fixes #1273

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@chudur-budur chudur-budur self-assigned this Jan 23, 2024
diptorupd
diptorupd approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to revise the documentation pages properly, but the changes in the PR are good.

@diptorupd diptorupd merged commit da3d1a0 into IntelPython:main Jan 23, 2024
41 of 46 checks passed
@diptorupd diptorupd deleted the fix/nuke-default-local-size branch January 23, 2024 02:50
github-actions bot added a commit that referenced this pull request Jan 23, 2024
@github-actions
Merge pull request #1291 from chudur-budur/fix/nuke-default-local-size
0d50743 
Remove DEFAULT_LOCAL_SIZE completely from the code da3d1a0
github-actions bot added a commit to chudur-budur/numba-dpex that referenced this pull request Jan 23, 2024
@github-actions
Merge pull request IntelPython#1291 from chudur-budur/fix/nuke-defaul…
3755d92 
…t-local-size

Remove DEFAULT_LOCAL_SIZE completely from the code da3d1a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@chudur-budur chudur-budur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEFAULT_LOCAL_SIZE use has been deprecated and should be removed
2 participants
@chudur-budur @diptorupd