Remove spirv-tool call generators from spirv_generator.py. #1292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you provided a meaningful PR description?
The spirv-tool package provides various utilities to
disassemble, validate and potentially optimize a
SPIR-V binary file. Numba-dpex no longer has spirv-tools
as a dependency and it is up to the user if they want to
try out the funtionalities provided by spirv-tools.
Having the option to call spirv-tool utilities from
spirv_generator is unused and potentially confusing. The
commit removes all such options and renames the helper
class from CmdLine to _SprivGenerator.
Also removed the config option to run spirv validator.
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?