Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spirv-tool call generators from spirv_generator.py. #1292

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

diptorupd
Copy link
Contributor

@diptorupd diptorupd commented Jan 23, 2024

  • Have you provided a meaningful PR description?

    • The spirv-tool package provides various utilities to
      disassemble, validate and potentially optimize a
      SPIR-V binary file. Numba-dpex no longer has spirv-tools
      as a dependency and it is up to the user if they want to
      try out the funtionalities provided by spirv-tools.

      Having the option to call spirv-tool utilities from
      spirv_generator is unused and potentially confusing. The
      commit removes all such options and renames the helper
      class from CmdLine to _SprivGenerator.

    • Also removed the config option to run spirv validator.

  • Have you added a test, reproducer or referred to an issue with a reproducer?

  • Have you tested your changes locally for CPU and GPU devices?

  • Have you made sure that new changes do not introduce compiler warnings?

  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd diptorupd requested a review from ZzEeKkAa January 23, 2024 04:14
@diptorupd diptorupd force-pushed the fix/remove_unused_code_spirv_generator branch from cc7e4cb to fff9bbc Compare January 23, 2024 18:00
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

    - The spirv-tool package provides various utilities to
      disassemble, validate and potentially optimize a
      SPIR-V binary file. Numba-dpex no longer has spirv-tools
      as a dependency and it is up to the user if they want to
      try out the funtionalities provided by spirv-tools.

      Having the option to call spirv-tool utilities from
      spirv_generator is unused and potentially confusing. The
      commit removes all such options and renames the helper
      class from CmdLine to _SprivGenerator.

    - Also removed the config option to run spirv validator.
@diptorupd diptorupd force-pushed the fix/remove_unused_code_spirv_generator branch from fff9bbc to d9eb596 Compare January 23, 2024 21:09
@diptorupd diptorupd merged commit 1608e43 into main Jan 23, 2024
47 of 51 checks passed
@diptorupd diptorupd deleted the fix/remove_unused_code_spirv_generator branch January 23, 2024 22:20
github-actions bot added a commit to chudur-budur/numba-dpex that referenced this pull request Jan 23, 2024
…d_code_spirv_generator

Remove spirv-tool call generators from spirv_generator.py. 1608e43
github-actions bot pushed a commit that referenced this pull request Jan 24, 2024
…v_generator

Remove spirv-tool call generators from spirv_generator.py. 1608e43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants