Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add linear indexing overload #1368

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Feature/add linear indexing overload #1368

merged 5 commits into from
Feb 28, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Feb 27, 2024 •
edited by diptorupd
Loading

Reimplement linear indexing functions so they can be used both in python and numba_jit and add those as an overload. Ideal way would be to use numba_dpex.extending.register_jitable but it does not support methods, so I had write some kind of workaround

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Fixes #199 (satisfied by get_global_linear_id or get_linear_id)

@ZzEeKkAa ZzEeKkAa requested a review from diptorupd February 27, 2024 13:52
@ZzEeKkAa ZzEeKkAa self-assigned this Feb 27, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_linear_indexing_overload branch 2 times, most recently from b50b4d7 to a425666 Compare February 28, 2024 04:02
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_linear_indexing_overload branch from a425666 to a8224c5 Compare February 28, 2024 18:19
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd February 28, 2024 18:19
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_linear_indexing_overload branch from a8224c5 to f953ca2 Compare February 28, 2024 20:27
@ZzEeKkAa ZzEeKkAa enabled auto-merge February 28, 2024 20:27
diptorupd
diptorupd approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ZzEeKkAa ZzEeKkAa merged commit 3d8c8fe into main Feb 28, 2024
54 of 60 checks passed
@ZzEeKkAa ZzEeKkAa deleted the feature/add_linear_indexing_overload branch February 28, 2024 21:10
github-actions bot added a commit that referenced this pull request Feb 28, 2024
@github-actions
Merge pull request #1368 from IntelPython/feature/add_linear_indexing…
3ed2b89 
…_overload

Feature/add linear indexing overload 3d8c8fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function of getting absolute position of the current work-item
2 participants
@ZzEeKkAa @diptorupd