Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend indexing function tests to kernel simulator #1378

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Extend indexing function tests to kernel simulator #1378

merged 1 commit into from
Mar 15, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Mar 7, 2024 •
edited
Loading

Run indexing functions tests both through numba and python simulator

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa force-pushed the feature/comprehensive_indexing_function_tests branch 3 times, most recently from 2496c08 to dce0f34 Compare March 12, 2024 00:26
@ZzEeKkAa ZzEeKkAa self-assigned this Mar 12, 2024
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd March 12, 2024 14:11
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review March 12, 2024 14:11
@ZzEeKkAa ZzEeKkAa force-pushed the feature/comprehensive_indexing_function_tests branch from dce0f34 to 95eb22e Compare March 12, 2024 14:13
diptorupd
diptorupd previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ZzEeKkAa ZzEeKkAa force-pushed the feature/comprehensive_indexing_function_tests branch 2 times, most recently from 4752af5 to 51310f9 Compare March 12, 2024 15:26
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd March 12, 2024 15:27
@ZzEeKkAa ZzEeKkAa force-pushed the feature/comprehensive_indexing_function_tests branch from 51310f9 to 7a8b6ca Compare March 15, 2024 03:35
@diptorupd
Copy link
Contributor

@ZzEeKkAa can you take a look at https://coveralls.io/builds/66307283/source?filename=numba_dpex%2Fkernel_api%2Findex_space_ids.py#L37. Adding some tests for 1-, 2-dimensional kernels for the linear id functions will improve coverage.

@ZzEeKkAa ZzEeKkAa force-pushed the feature/comprehensive_indexing_function_tests branch from 7a8b6ca to 632f4b8 Compare March 15, 2024 14:59
@ZzEeKkAa
Copy link
Contributor Author

@diptorupd 100% agree with you, but this is not a point of this PR. It does not introduce any new tests, just makes sure that all tests are run both on device and through simulator.

@diptorupd diptorupd merged commit 9fd6cdc into main Mar 15, 2024
65 checks passed
@diptorupd diptorupd deleted the feature/comprehensive_indexing_function_tests branch March 15, 2024 16:24
github-actions bot added a commit that referenced this pull request Mar 15, 2024
@github-actions
Merge pull request #1378 from IntelPython/feature/comprehensive_index…
fb6edd4 
…ing_function_tests

Extend indexing function tests to kernel simulator 9fd6cdc
github-actions bot added a commit to diptorupd/numba-dpex that referenced this pull request Mar 15, 2024
@github-actions
Merge pull request IntelPython#1378 from IntelPython/feature/comprehe…
fb2bec4 
…nsive_indexing_function_tests

Extend indexing function tests to kernel simulator 9fd6cdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd