Do not selectively apply spirv exts unconditionally do so in spirv_generator #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adarshyoga
approved these changes
Mar 15, 2024
diptorupd
force-pushed
the
unconditionally_apply_spv_exts
branch
from
99f6015 to
91f9894
Compare
github-actions bot
added a commit
that referenced
this pull request
Mar 15, 2024
Do not selectively apply spirv exts unconditionally do so in spirv_generator af24e66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the experimental SPIR-V overloads such as the AtomicRef overloads try to set needed SPIR-V extensions flags only for a module that uses such an overload. However, the functionality is broken (see #1262) and needs deeper design changes than are warranted.
We are unconditionally adding needed SPIR-V extension flags in the
spirv_generatormodule. The solution is adequate for now and perhaps should be THE long-term solution.This PR removes the essentially dead code of adding extra SPIR-V extension flags inside AtomicRef overloads.