[Documentation] Programming Model, Kernel Programming guide #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview: show. |
diptorupd
force-pushed
the
docs/programming_model
branch
4 times, most recently
from
922a7a9 to
67400a3
Compare
adarshyoga
reviewed
Mar 19, 2024
adarshyoga
reviewed
Mar 19, 2024
Comment on lines
35
to
43
| executes a single addition. Note that the array sizes for the input and output | ||
| arguments are equal to the size of the execution range. For very large arrays, | ||
| the design will not scale as there is usually an upper bound for the range size | ||
| depending on device. For most current Intel GPU devices, the maximum range size | ||
| is 2^32 and a kernel requesting more work items than that bound will not | ||
| execute. As such, programmers need to consider the size of the data and the | ||
| access patterns for their kernels before scheduling a range kernel. The maximum | ||
| number of work items can be queried programmatically as shown in | ||
| :ref:`ex_max_work_item`. |
There was a problem hiding this comment.
I think this chunk can be better explained in terms of maximum range limit instead of maximum array size because you have always have arrays larger than max range and map multiple array elements to a single work-item.
Moreover, this piece of text seems like a better fit in the below section where semantic rules are explained.
There was a problem hiding this comment.
I have restructured the section. Hopefully, it reads better now.
adarshyoga
reviewed
Mar 19, 2024
docs/source/user_guide/kernel_programming/writing-range-kernel.rst
Outdated
Show resolved
Hide resolved
diptorupd
force-pushed
the
docs/programming_model
branch
3 times, most recently
from
86636d9 to
02523ca
Compare
|
@adarshyoga can you please give the Kernel programming guide a read once more. I have updated the all the section except the |
diptorupd
force-pushed
the
docs/programming_model
branch
2 times, most recently
from
7c6906a to
b189e38
Compare
adarshyoga
approved these changes
Mar 26, 2024
diptorupd
force-pushed
the
docs/programming_model
branch
from
b189e38 to
f82360b
Compare
|
Documentation preview removed. |
github-actions bot
added a commit
that referenced
this pull request
Mar 27, 2024
[Documentation] Programming Model, Kernel Programming guide 8e3b63d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new material to the kernel programming guide and the programming model sections.
Fixes #1042